Add default project to organization default settings #1634
+393
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrombley
force-pushed
the
ctrombley/TF-14884
branch
from
f21b615 to
46ed87a
Compare
ctrombley
force-pushed
the
ctrombley/TF-14884
branch
from
90d823e to
8f4df19
Compare
netramali
reviewed
Mar 5, 2025
| options.DefaultProject = jsonapi.NewNullableRelationshipWithValue(project) | ||
| } else if !stateData.DefaultProjectID.IsNull() { | ||
| // If the project ID is being removed, we need to set it to null | ||
| options.DefaultProject = jsonapi.NewNullNullableRelationship[*tfe.Project]() |
There was a problem hiding this comment.
@ctrombley After thinking about it again, if !stateData.DefaultProjectID.IsNull() and planData.DefaultProjectID.IsNull() --> basically if the user didn't provide default project id but it already exists, we shouldn't remove it.
An approach we can take is to make the default project id required field. What do you think about that?
The other option is that we only ever do this options.DefaultProject = jsonapi.NewNullNullableRelationship[*tfe.Project]() when the plan has an explicit null set for the default project id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In atlas, we can now update the default project hence we need to add default project id to the organization default settings.
Note:
Remember to:
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from Documentation Preview
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.